Updating UbuntuNetCoreKeyring dockerfile to use net core 5 #17980
Conversation
schaabs
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
|
/azp run net - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Update ubuntu netcore keyring dockerfile to use net 5
|
/azp run net - docker-containers-publish |
|
No pipelines are associated with this pull request. |
|
/azp list |
|
|
||
| ENV \ | ||
| NO_AT_BRIDGE=1 \ | ||
| DOCKER_CONTAINER_NAME="ubuntu_netcore_keyring" \ | ||
| PSModuleAnalysisCachePath=/var/cache/microsoft/powershell/PSModuleAnalysisCache/ModuleAnalysisCache \ | ||
| POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetCoreSDK-Ubuntu-18.04 | ||
| POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetCoreSDK-Ubuntu-20.04 |
There was a problem hiding this comment.
Does .NET 5 require Ubuntu20?
There was a problem hiding this comment.
I mostly ask because we are still using ubuntu 18 in most of our other pipelines.
There was a problem hiding this comment.
I didn't see a docker image for 5.0 based on Ubuntu 18 in the the full tag listing here. If you think it's an issue to use Ubuntu 20 here we can build our own image.
There was a problem hiding this comment.
Interesting they seem to support .NET 5 on 18.04 (https://docs.microsoft.com/en-us/dotnet/core/install/linux#ubuntu) but they don't publish a docker container. I don't know of any specific issues with Ubuntu 20.04 currently but I know the last time we tried moving there were some sorting issues due to some cultural library changes in the OS. You can certainly try 20.04 if that is easier but if you start seeing weird issues we might want to reconsider until we move everything to 20.04.
There was a problem hiding this comment.
@weshaggard the only issue we've found so far was python was not installed by default, but if we see more we can build one from 18.04.
…/azure-sdk-for-net into keyring-container-update
|
Hi @schaabs. There hasn't been recent engagement on this PR. If this is still an active work stream, please let us know by removing the |
jsquire
added
the
no-recent-activity
|
@schaabs this needs to be merged given our use of the image. |
No description provided.